search

threshold-network / token-dashboard

23 stars 24 forks source link

Simple TACo images #684

Closed derekpierre closed 9 months ago

derekpierre commented 9 months ago

Short-term quick and dirty fixes for TACo application images.

In the medium/longer-term the original png images should be provided as SVG images so that they can more easily be edited.

Notes for reviewers: I'm less familiar with this codebase, so if I missed anything let me know.

derekpierre commented 9 months ago

@theref not sure what's up with CI - could you take a look?

piotr-roslaniec commented 9 months ago

@derekpierre You need to update the yarn.lock lockfile with yarn install. I've tried doing it myself but I don't have write access to your branch.

cygnusv commented 9 months ago

@theref not sure what's up with CI - could you take a look? @derekpierre You need to update the yarn.lock lockfile with yarn install. I've tried doing it myself but I don't have write access to your branch.

Apart from this, in this repo we need to create PRs from branches, not from forks, so CI works properly

piotr-roslaniec commented 9 months ago

@cygnusv I think we need some permissions to push to the origin branches

ERROR: Permission to threshold-network/token-dashboard.git denied to piotr-roslaniec. fatal: Could not read from remote repository.

Please make sure you have the correct access rights and the repository exists.

derekpierre commented 9 months ago

Closed in favour of https://github.com/threshold-network/token-dashboard/pull/686