threshold-network / token-dashboard

22 stars 23 forks source link

Handling of taproot addresses on the Unmint form needs improvement #760

Open michalinacienciala opened 2 months ago

michalinacienciala commented 2 months ago

I noticed several issues with handling of the situation when user provides a taproot address in the BTC Address field on the Unmint form. Generally, the taproot addresses should not be allowed.

  1. When the field is empty and user enters the taproot address (for example tb1p9vqac4a6lyda7zhvpw9z4qtxjx8ase9c82td4q9j8arlhrl0ujjs97z4az, on testnet), the field gets highlighted in red (OK), but the error message is not descriptive: Required. (NOOK).

  2. The Unmint button is active despite the fact that user provided unsupported address.

  3. Proceeding with the unmint after providing taproot address results in warnings and errors thrown in the console, but there is no information about the error in the dapp and the spinning wheel on the unmint button spins indefinitely.

https://github.com/threshold-network/token-dashboard/assets/78352137/e11350eb-7f64-4da3-b5c2-f48ca6154a4a