search

thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
101 stars 53 forks source link

Expose stream protocol method to close Writer #506

Closed dianale31 closed 3 years ago

dianale31 commented 3 years ago

Provides a stream protocol method to close out the resources of the given Writer.

The corresponding Close() method on Reader will be implemented in a follow-up PR.

codecov[bot] commented 3 years ago

Codecov Report

Merging #506 (a7ec0e3) into streamdev (8405012) will decrease coverage by 2.67%. The diff coverage is 0.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##           streamdev     #506      +/-   ##
=============================================
- Coverage      71.48%   68.80%   -2.68%     
=============================================
  Files            129      129              
  Lines          18615    22738    +4123     
=============================================
+ Hits           13307    15646    +2339     
- Misses          3642     4068     +426     
- Partials        1666     3024    +1358
Impacted Files Coverage Δ
protocol/binary/stream_writer.go 63.07% <0.00%> (-2.01%) :arrow_down:
gen/stream.go 84.00% <0.00%> (-16.00%) :arrow_down:
gen/internal/tests/exceptions/exceptions.go 62.90% <0.00%> (-7.19%) :arrow_down:
.../internal/tests/hyphenated-file/hyphenated-file.go 63.21% <0.00%> (-6.14%) :arrow_down:
.../internal/tests/hyphenated_file/hyphenated_file.go 63.21% <0.00%> (-6.14%) :arrow_down:
gen/internal/tests/unions/unions.go 65.52% <0.00%> (-5.36%) :arrow_down:
gen/internal/tests/containers/containers.go 57.42% <0.00%> (-4.73%) :arrow_down:
gen/internal/tests/services/services.go 62.83% <0.00%> (-3.31%) :arrow_down:
gen/internal/tests/typedefs/typedefs.go 69.26% <0.00%> (-2.57%) :arrow_down:
internal/envelope/exception/exception.go 82.80% <0.00%> (-2.15%) :arrow_down:
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8405012...a7ec0e3. Read the comment docs.