thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
101 stars 53 forks source link

Upgrade to Ragel version 6.10 (from 6.9) #523

Closed jparise closed 3 years ago

jparise commented 3 years ago

This doesn't change anything in current practice aside from moving to the latest stable version of Ragel. From the changelog:

Ragel 6.10 - Mar 24, 2017

-C codegen: test P vs PE in goto/call/ret statements in EOF actions, just before re-entering. If at the end of the input block then the EOF check is jumped to. This change prevents overrunning the buffer if control flow is issued in an EOF action without fixing the input pointer first. If a program properly issues an fhold before the control flow the program won't be affected. -Updated action label generation. The previous set of conditions for generating the label didn't cover actions coming from the eofAction pointer (eof trans covered since it points into the set of transitions). -Use separate signed/unsigned values for host type min/max. Using separate values avoids the need to type cast before the data goes into FsmCtx structs. Keep it in native types until it is used. -Optionally do not generate entry point variables. Adds noentry write option for data. -Various warning elimination and build updates.

codecov[bot] commented 3 years ago

Codecov Report

Merging #523 (498465b) into dev (14808ba) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #523   +/-   ##
=======================================
  Coverage   79.02%   79.02%           
=======================================
  Files         129      129           
  Lines       16092    16092           
=======================================
  Hits        12716    12716           
  Misses       2066     2066           
  Partials     1310     1310           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14808ba...498465b. Read the comment docs.

abhinav commented 3 years ago

thanks!