search

thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
101 stars 53 forks source link

gen/quick_test: Add missing types #525

Closed abhinav closed 3 years ago

abhinav commented 3 years ago

Usually, when we add a new type to gen/internal/tests/thrift, we should add an entry to gen/quick_test to get some high level testing (and coverage) on the generated code for those types.

codecov[bot] commented 3 years ago

Codecov Report

Merging #525 (7efd675) into streamdev (c206ae1) will increase coverage by 0.38%. The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           streamdev     #525      +/-   ##
=============================================
+ Coverage      68.83%   69.22%   +0.38%     
=============================================
  Files            131      131              
  Lines          22769    22769              
=============================================
+ Hits           15673    15761      +88     
+ Misses          4071     3953     -118     
- Partials        3025     3055      +30
Impacted Files Coverage Δ
gen/internal/tests/structs/structs.go 62.87% <0.00%> (+1.26%) :arrow_up:
gen/internal/tests/set_to_slice/set_to_slice.go 58.17% <0.00%> (+4.28%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c206ae1...7efd675. Read the comment docs.