search

thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
101 stars 53 forks source link

Fixing a bug in thriftbreak to detect commit changes that add a new file #550

Closed shirchen closed 3 years ago

shirchen commented 3 years ago

Fixing a bug where a new file gets added in addition to other thrift changes would cause a panic.

Ref GO-963

codecov[bot] commented 3 years ago

Codecov Report

Merging #550 (edab1ad) into dev (22b9cf4) will decrease coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #550      +/-   ##
==========================================
- Coverage   68.01%   67.99%   -0.02%     
==========================================
  Files         139      139              
  Lines       23724    23704      -20     
==========================================
- Hits        16136    16118      -18     
+ Misses       4535     4534       -1     
+ Partials     3053     3052       -1
Impacted Files Coverage Δ
internal/breaktest/repo.go 77.14% <100.00%> (-8.83%) :arrow_down:
internal/git/git.go 68.42% <100.00%> (+3.55%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 22b9cf4...edab1ad. Read the comment docs.