thriftrw / thriftrw-go

A Thrift encoding code generator and library for Go
MIT License
100 stars 53 forks source link

ci: Fix make lint and test against go1.19 and go1.20 #575

Closed r-hang closed 1 year ago

r-hang commented 1 year ago

In upgrading the CI to test against go1.20 and go1.19 I realized that 'make lint' is currently broken on dev. I've fixed the broken lint CI step as well as updating CI to test against the latest go versions.

codecov[bot] commented 1 year ago

Codecov Report

Merging #575 (5e6a38f) into dev (2af8df0) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##              dev     #575   +/-   ##
=======================================
  Coverage   68.00%   68.00%           
=======================================
  Files         140      140           
  Lines       23872    23872           
=======================================
  Hits        16233    16233           
  Misses       4578     4578           
  Partials     3061     3061           
Impacted Files Coverage Δ
ast/annotation.go 91.66% <ø> (ø)
ast/constant.go 46.42% <ø> (ø)
ast/definition.go 74.50% <ø> (ø)
ast/header.go 40.00% <ø> (ø)
ast/type.go 33.84% <ø> (ø)
compile/namespace.go 100.00% <ø> (ø)
gen/generator.go 67.23% <ø> (ø)
gen/list.go 98.81% <ø> (ø)
gen/map.go 98.85% <ø> (ø)
gen/set.go 98.98% <ø> (ø)
... and 9 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

CLAassistant commented 1 year ago

CLA assistant check
All committers have signed the CLA.