codecov[bot]
commented
1 year ago Codecov Report
Merging #578 (86d21fa) into dev (6268dfe) will not change coverage. The diff coverage is
100.00%.:exclamation: Current head 86d21fa differs from pull request most recent head c7a5992. Consider uploading reports for the commit c7a5992 to get more accurate results
@@ Coverage Diff @@
## dev #578 +/- ##
=======================================
Coverage 68.00% 68.00%
=======================================
Files 140 140
Lines 23872 23872
=======================================
Hits 16233 16233
Misses 4578 4578
Partials 3061 3061 | Impacted Files | Coverage Δ | |
|---|---|---|
| gen/string.go | 78.57% <100.00%> (ø) |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
After rebasing #574 on top of #577 and running GO111MODULE=on make lint I still see some errors.
cmd/thriftbreak/main_test.go:26:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019) gen/string.go:66:15: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019)
After this change:
$ git log --oneline a054ce6 (HEAD -> optimise_read_string) Fix remaining lint errors 2c1d285 build tags 8a1aa7d address review comments f26170a inline 41dacbd remove bench reports 4ad4d9c optimise write string fb22d6e optimise readstring() 6268dfe (origin/dev, origin/HEAD) Remove all usages of io/ioutil (#577)
$ GO111MODULE=on make lint Checking gofmt Checking govet Checking golint Checking staticcheck $ echo $? 0
I've cherry-picked the contents of the HEAD commit displayed above into a separate branch for a PR to dev.