Remove relative path checks in thrift includes

thriftrw / thriftrw-node

A thrift binary encoding library using bufrw

MIT License

57 stars 25 forks source link

Remove relative path checks in thrift includes #160

Closed rajeshsegu closed 5 years ago

rajeshsegu commented 5 years ago

Rest of the thriftrw language clients have support for just having include "typedefs.thrift" instead of specifying relative path as in include "./typedefs.thrift"

CLAassistant commented 5 years ago

All committers have signed the CLA.

kriskowal commented 5 years ago

Does this preclude the possibility of supporting an IDL root path in the future? Have we surveyed the behavior of the Apache Thrift implementations? Do they all resolve paths relative to the file, or the working directory of the generator?