fix mutable default args handling

thriftrw / thriftrw-python

A Thrift encoding library for Python

MIT License

36 stars 10 forks source link

fix mutable default args handling #127

Closed chirayuk closed 8 years ago

chirayuk commented 8 years ago

thriftrw treats default args in a surprising way—the same way in which Python treats mutable default args—but thrift specs are definitely NOT Python. This caused a pretty weird bug as I tried to switch over.

I couldn't build this repo on my macbook so I haven't added any test cases yet.

abhinav commented 8 years ago

Hi. Have a look at CONTRIBUTING.md for instructions on how to build this locally.

chirayuk commented 8 years ago

Thanks @abhinav. I'll check it out.

abhinav commented 8 years ago

Superseded by https://github.com/thriftrw/thriftrw-python/pull/129