search

thriftrw / thriftrw-python

A Thrift encoding library for Python
MIT License
36 stars 10 forks source link

Support enums from the future #154

Closed abhinav closed 6 years ago

abhinav commented 6 years ago

Despite our internal documentation and communications stating otherwise, we weren't handling unrecognized enum values correctly. Validation would fail on unrecognized enum values.

This change fixes this behavior by allowing enum values from the future.

Ref: T2223161

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.1%) to 74.415% when pulling d383a266e6a639bd222bc73221d97fe5a36c8fde on enum-from-the-future into 7cd851f0402b6f8d2af42c73b979f4d47f6c8471 on master.

akshayjshah commented 6 years ago

:+1: I'm also bummed that we just ran into this.