thrimbor / sbep

Spacebuild Enhancement Pack
0 stars 1 forks source link

License change #1

Open thrimbor opened 10 years ago

thrimbor commented 10 years ago

So, this the proposed attempt to change the sbep license from GPL to Apache License, Version 2.0 in order to be compatible with the Steam workshop license. As everyone who contributed is a copyright holder, everyone needs to agree with the new license for the change to be successfull (or his contribution would need to be removed). I created this issue to reach out to everyone who contributed to sbep here on github, I will contact the contributors of the google-code svn per mail.

So, if you contributed to sbep here on github, please leave a comment whether you agree with the license change.

If and when this is successfull, i will add the new license statement to the repository and provide a pull request to SnakeSVx.

ping @selekton99 @SnakeSVx @DataSchmuck @Dracyr @nirahiel @LoRAWN @RevoluPowered @ExE-Boss @X-Coder @Tingle1337 @hopkinskong

Current state:

Name E-Mail available agreed to license
SnakeSVx - yes
selekton99 - yes
DataSchmuck - yes
Dracyr - yes
nirahiel - yes
LoRAWN - yes
RevoluPowered - ?
ExE-Boss - yes
X-Coder - yes
Tingle1337 - ?
hopkinskong - ?
tjohnman - yes
generalwrex - ?
natrim - yes
CerusVI yes ?
foxrox (Slyfo) yes yes
glenskunk yes yes
Hysteria (unintendedhysteria) yes yes
Jhaxby1 yes ?
Paradukes yes ?
punisher239 yes yes
richard.maw yes yes
copy112 no yes
levybreak098 yes yes
Shanjaq no(t yet?) ?
theappleofpineappe no(t yet?) ?
thomasevansenator no(t yet?) ?
firgof.umbra yes yes
binarysudokumusic yes ?
PHX - yes
asphid.jackal yes yes
megamadgamer yes yes
robojoos yes yes
sgtoverkiller yes ?
DarthPJB yes yes
hzzzln no ?
ReaperSWE no ?
votekick no ?
yoman258 no ?
samcooke98 commented 10 years ago

Remember who originally made the models? Slyfo, Krieg and plenty others that I don't know. Good luck with this.

thrimbor commented 10 years ago

Yes, that's why I will try to contact them, their names still can be found in the svn-log. This issue and the approval of the github-contributors is only the first of the necessary steps.

DataSchmuck commented 10 years ago

I agree with the new license change, and all future license changes.

X-Coder commented 10 years ago

I did only some smaller fixes, but I fully agree too. Workshop is great for getting new users into spacebuild.

Dracyr commented 10 years ago

Same with me, did some small fixes, and i agree on the license change.

SnakeSVx commented 10 years ago

I agree to the license change. Both SB and SBEP. I'll make the changes to the official SB git when it is all done. Could you do a pull-request to the sbep one when done? I'll aprove it then.

thrimbor commented 10 years ago

Ok, here's a list of the svn contributors, taken from the sbep and spacebuild svn: moved table to the first post

These people appeared in the memberlist of the project, but I couldn't find them in the commit logs: moved table to the first post I'll just mail them anyway just to be on the safe side.

Feel free to tell me when I missed someone or if you can provide contact information for the people I don't have the e-mail address of.

@SnakeSVx You mentioned that you probably could contact copy112 and Hyteria. Could you try that?

Because changing the spacebuild license too is only logical, let's ping them too: @tjohnman @generalwrex @natrim

I'll send out the first mails in a few minutes and keep the table up to date.

SnakeSVx commented 10 years ago

I messaged Hysteria (already received the email), Glenskunk, Phoenix and portal (Copy112, AGREED) on steam.

monty8466 commented 10 years ago

I agree with this change. (I am on the list twice above, as both Hysteria and unintendedhysteria.)

I have Slyfo on Steam - if I see him online, I'll send him this thread.

GlenSkunk commented 10 years ago

Fancy seeing this still going! I of course agree with this change - it will be interesting to see some of this work pop up through Steam Workshop!

PhoeniX-Storms commented 10 years ago

PHX reporting for duty! I agree for the license change.

thrimbor commented 10 years ago

I already received some anwers per mail (which is very nice), so here comes the updated and corrected list: moved table to the first post

@PhoeniX-Storms Were you already on the list under another name or were you missing?

SnakeSVx commented 10 years ago

He was missing and Copy 112 agreed on steam, so you can put yes next to him

thrimbor commented 10 years ago

Neat. I updated the table.

SnakeSVx commented 10 years ago

What is the limit actually for the workshop?

thrimbor commented 10 years ago

Size limit? Don't know, the biggest addon I have is over 320 MB (uncompressed). I only know that there is a bug in the dedicated server which leads to addons not getting downloaded when the compressed file is bigger than 64 MB.

X-Coder commented 10 years ago

Garry wrote a while ago Valve's limit is at 100MB, but looking through my addon folder, there are some gma files up to 300MB, so I'm not sure about the 100MB limit, maybe its because its not compressed in this folder.

Carter's Addon Pack was splitted into severall 100MB seperate workshop addons to overcome the limit and then they put all into one collection, so people just need to subscribe to the collection.

X-Coder commented 10 years ago

thrimbor, I never had this issue on my windows server, but I heard about it too. Don't know if this bug was fixed. The way I use it for my server is, I put all the addons I want to sync with workshop into a private workshop collection and let the server sync the collection.

weswigham commented 10 years ago

Hiya! Levy here! It's been awhile since I've looked at this. So long as it remains open source and open to community contributions, I'm perfectly happy with a license change (to both - I worked on both at one point).

My sole request is that since you've already gone through the effort of finding everybody involved in the project in the past, and the new license provides for such, I propose that these basic attributions be included in the 'NOTICE' file in the root of the project (which is allowed/encouraged by the new license) - this way if it is ever modified or redistributed all of this... history from the past repositories is still present and preserved (with contact information, should this ever need to be done again in the future).

Also, I'm pretty sure I can contact LPine, I still talk to him every now and then.

As for your confusion over people who hadn't appeared in the commit logs - that's because there have been multiple sbep repos on googlecode, with multiple commit logs. (Remembering that it used to be called the spacebuild model pack, here are the ones I've dug up from just before/around my time with the project.)

thrimbor commented 10 years ago

I think this is a good idea, but we'd need to be careful with the contact information - I'm pretty sure that not everybody wants his email/whatever exposed to the public. Btw. I updated the table and moved it to the first post, I'll just keep it updated there. I'll also dig through the other svn logs.

LoRAWN commented 10 years ago

I agree to the license change.

thrimbor commented 10 years ago

I went though the svn-logs mentioned by weswigham and found a few names that weren't present in the table yet. I'll add them to the table, but I only found the mail-addresses of some of them (ReaperSWE's address is unreachable).

natrim commented 10 years ago

@thrimbor i have no problem with license change

DarthPJB commented 10 years ago

It's been a long time boys! It still brings a tear to my eye to see the project active after all this time.

I'm happy with the new licence with one condition.

When I started the Space-build Model-Pack project (a long time ago) I promised three things.

  1. Cheeseman55 would be credited for the original Idea - Forever.
  2. There would be a little batman style light with my name one it (the PJB light, it's in the original pack).

with those two conditions met and correct accreditation to myself and all other contributors, I'd call the licence change a very good idea.

If your wondering why I'm so jittery about the accreditation (because we all know it means little online) Once we switch to an open licence such as Apace, the share-alike modification means ONLY the credits remain of the original authors.

If there are any issues with this, please drop me an e-mail.

tjohnman commented 10 years ago

I agree to the license change.

Glad to see this is still alive and kicking!

samcooke98 commented 10 years ago

I agree with the license change. Though perhaps adding people to the steam workshop page may be a good idea?

nirahiel commented 10 years ago

Meh, i'm fine. We got to keep our names in ?

thrimbor commented 10 years ago

@DarthPJB Ok, that can be done. Can you provide a pull request with the light in it so I can just merge it in the license-change branch? @nirahiel The commit history will remain intact, so your name will still be found there. I also think that weswigham's suggestion with the NOTICE-file is a good idea, so I think I will add all names to it too, so nobody will be forgotten.

DarthPJB commented 10 years ago

@thrimbor, That I can do - It may be useful to you that the original documentation and information are still held on google-code https://code.google.com/p/spacebuildmodelpack/

The PJB-Light model was added in Revision #99 https://code.google.com/p/spacebuildmodelpack/source/browse/?r=99

and can be found in the applicable models folder of that time. https://code.google.com/p/spacebuildmodelpack/source/browse/?r=99#svn%2Ftrunk%2FSpacebuildModelPackAlpha2%2Fmodels%2FSpacebuild

If I may recommend as such, it may be worth investigating if any other models from the old repo have been removed that may still be worth reintroduction?

[Edit] Unfortunately I'm used to google-code and codebase - Not too familiar with githubs pull request system. If you want, I can go ahead and create a commit for the light?

thrimbor commented 10 years ago

Ok, we made progress, but we don't have everyones approval yet. Is anyone able to contact the people I haven't been able to reach? I'll ping the ones on github with this post.

@RevoluPowered @ExE-Boss @Tingle1337 @hopkinskong @generalwrex

thrimbor commented 10 years ago

@DarthPJB For a pull request you'd need to fork the project (SnakeSVx's master branch, the license-change branch is based on that), add the commit and then send a pull request to me with the commit attached. I'll maybe be able to look into adding it myself but it'd probably take some time.

asphid-jackal commented 10 years ago

I very rarely check my email, so sorry for the long delay. I agree to the change, but I contributed so little so long ago I'm willing to renounce any sort of copyright holdings I have or had.

ExE-Boss commented 10 years ago

I agree with the licence change as well

thrimbor commented 10 years ago

Ok, it's been over a month now, I think it's time to actually change the license. As we were unable to contact everyone, I think it's best to do it like the wiremod and VLC projects did it: We change the license, and everyone who hasn't agreed yet can contact us and we'll figure something out if he doesn't agree with the change.

Pull requests are on their way.

SnakeSVx commented 10 years ago

Ok, sounds like a good plan.

2014-05-26 13:53 GMT+02:00 Stefan Schmidt notifications@github.com:

Ok, it's been nearly a month now, I think it's time to actually change the license. As we were unable to contact everyone, I think it's best to do it like the wiremod and VLC projects did it: We change the license, and everyone who hasn't agreed yet can contact us and we'll figure something out if he doesn't agree with the change.

Pull requests are on their way.

— Reply to this email directly or view it on GitHubhttps://github.com/thrimbor/sbep/issues/1#issuecomment-44182318 .

Mvg/Kind regards,

Stijn

ExE-Boss commented 9 years ago

I'd just like to say that the proper way to write my name is: "ExE Boss". I use "ExE-Boss" on GitHub, because GitHub doesn't support spaces or underscores in usernames.