search

thrumdev / nomt

Apache License 2.0
96 stars 5 forks source link

refactor: expunge FatPage from beatree/leaf #490

Closed rphmeier closed 2 weeks ago

rphmeier commented 2 weeks ago

Similar to the previous PR, I replaced uses of FatPage with raw Pages in leaf logic.

rphmeier commented 2 weeks ago

[!WARNING] This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite. Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @rphmeier and the rest of your teammates on Graphite Graphite

rphmeier commented 2 weeks ago

Closed as I couldn't measure any performance benefit.

rphmeier commented 2 weeks ago

We may want to revive this, or simply take another approach (for example, setting some kind of global before doing lots of FatPage deallocations