search

thruster-rs / Thruster

A fast, middleware based, web framework written in Rust
MIT License
1.06k stars 47 forks source link

Alias ideas #209

Closed ynuwenhof closed 1 year ago

ynuwenhof commented 2 years ago

Hey,

Here's a small collection of alias ideas that I find to be fitting.

Ordered from best to worst, IMO.

use_sub_app

use_middleware

I might come up with some more alias ideas soon 👍

trezm commented 2 years ago

I like your top choice for both of those! I struggle to remember my original logic around choosing the existing names, but I think these options are really nice and succinct.

Israel-Laguan commented 1 year ago

What about router or similar for subapp?

trezm commented 1 year ago

I think that's a reasonable alias! Subapp has always felt a little... Poorly named to me? I'll put up a PR with the alias this afternoon.

On Sun, Aug 28, 2022, 5:17 PM Israel Antonio Rosales Laguan < @.***> wrote:

What about router or similar for subapp?

— Reply to this email directly, view it on GitHub https://github.com/thruster-rs/Thruster/issues/209#issuecomment-1229555303, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJWOLKNALR2QAZTMJYBSF3V3PJOPANCNFSM5O66XF5A . You are receiving this because you commented.Message ID: @.***>

Israel-Laguan commented 1 year ago

Also, router is the usual name in other languages and libraries.

BTW, great work for this library, our team is leveraging it to try it above other ones!

trezm commented 1 year ago

Should be resolved by https://github.com/thruster-rs/Thruster/pull/222, will put out a new release soon!

trezm commented 1 year ago

Should now be available in release 1.2.5! https://github.com/thruster-rs/Thruster/pull/223