Open maecompany opened 2 years ago
Hi @mbonneau, we would also appreciate to do this update, because dependencies update. Here is MR: https://github.com/thruway/ratchet-transport/pull/5 Thank you very much!
I'm using PHP 8.2 and there is deprecation warning like the following in guzzlehttp/psr7
1.7:
Deprecated: Creation of dynamic property GuzzleHttp\Psr7\CachingStream::$stream is deprecated
It's already fixed in guzzlehttp/psr7 since 2.4.0, but I can't update guzzlehttp/psr7
to 2.x, coz thruway/ratchet-transport
locked with "guzzlehttp/psr7": "^1.4"
So would be really great if the thruway/ratchet-transport
supported guzzlehttp/psr7 2.x
.
@mbonneau could you please review merge the #5?
Currently "guzzlehttp/psr7" is locked to the ^1.4 version range in
composer.json
.This is blocking us from upgrading our stack, because several other dependencies (for example codeception/module-rest) now require guzzlehttp/psr7 versions 2.x and up.
Would it be possible to add support for the 2.x range by changing
"guzzlehttp/psr7": "^1.4"
to"guzzlehttp/psr7": "^1.4 || ^2.0"
?The only change needed is updating this line to:
$queryParams = \GuzzleHttp\Psr7\Query::parse($request->getUri()->getQuery());