search

thscharler / spreadsheet-ods

Apache License 2.0
29 stars 6 forks source link

mktemp is have a copileft license #36

Closed Shatur closed 9 months ago

Shatur commented 1 year ago

I noticed that this create uses mktemp which have MPL license. But this crate is released under MIT/Apache. But these licenses are not compatible, MIT is more restrictive. I'm not a lawyer, but I'm not sure if it's possible to use it like this.

thscharler commented 1 year ago

afaik it should be ok

Shatur commented 1 year ago

Closing then, just wanted to make sure that you are aware.

Shatur commented 1 year ago

I just noticed that Bevy, for example, deny copyleft licenses because its license is not copyleft: https://github.com/bevyengine/bevy/blob/ebdf5063df5d2b89f4bf94b52eef03ad027fb8e3/deny.toml#L13 If I understand correctly, MIT is way more permissive.

thscharler commented 1 year ago

Yes, it seems MPL is somehow a weak copyleft license, but I am no expert.

But this deny.toml looks interesting, is this a standard cargo feature or some extension. Never seen this before?

Shatur commented 1 year ago

But this deny.toml looks interesting, is this a standard cargo feature or some extension. Never seen this before?

It's a separate tool called cargo-deny: https://github.com/EmbarkStudios/cargo-deny

Shatur commented 9 months ago

No longer used in the crate, closing.

thscharler commented 9 months ago

Yes, I did some work recently, and found I no longer need this. I think it was some workaround a bug in the zip crate, but I'm no longer sure. Anyway it's gone now ...