thscharler / spreadsheet-ods

Apache License 2.0
29 stars 6 forks source link

`color-rs` causes compilation issues #49

Closed Shatur closed 3 months ago

Shatur commented 4 months ago

The problem described and fixed in https://github.com/arturoc/color-rs/pull/2. But looks like the crate is not actively maintained. Maybe replace it with another crate?

thscharler commented 4 months ago

Yes I've seen this too.

As a quick-fix for my own uses I use a local copy of color-rs for my compilation.

I think I will wait for a few more days if there is any reaction to this. Afterwards I'm not sure.

I would prefer not to fork color-rs or to vendor it into spreadsheet-ods, and I haven't looked for a replacement yet.

You got any suggestions for a replacement?

mirsella commented 4 months ago

The crate maintainer just merged the fix !

thscharler commented 3 months ago

This is not resolved yet, waiting for a release of color-rs.

thscharler commented 3 months ago

Fixed with release 0.22.3.

I use num-traits = "=0.2.18" which fixes the miscompile of color-rs.