search

thscharler / spreadsheet-ods

Apache License 2.0
30 stars 6 forks source link

push_rowname and push_colname can overflow #6

Closed RustyNixieTube closed 4 years ago

RustyNixieTube commented 4 years ago

these functions can overflow if the input equal ucell::MAX:

pub(crate) fn push_colname(buf: &mut String, mut col: ucell);
pub(crate) fn push_rowname(buf: &mut String, mut row: ucell);

for example:

let c = CellRef::local(ucell::MAX, ucell::MAX);
println!("{}", c); //calling Display trait call  push_colname and push_rowname

can I rewrite these functions please?

RustyNixieTube commented 4 years ago

P.S. can I add for example a discord server for talking(creating an issue each time i have a question is boring)?

thscharler commented 4 years ago

sry, was busy with other things. I will look over this immedately.

a discord would be ok, but I've never used this before. wouldn't know how to set it up.

RustyNixieTube commented 4 years ago

a discord would be ok, but I've never used this before. wouldn't know how to set it up.

i can try to do the discord server

RustyNixieTube commented 4 years ago

I created the discord server @thscharler https://discord.gg/g4VEHZV (click on the link)

RustyNixieTube commented 4 years ago

oopsi wrong button sry