thsmi / sieve

Sieve Script Editor
GNU Affero General Public License v3.0
729 stars 56 forks source link

Traceback in log despite graceful exit #905

Open madduck opened 9 months ago

madduck commented 9 months ago

Prerequisites

What happened?

If a user just closes the tab without disconnecting (which all users will do), the logs get a traceback:

2023-10-13 12:18:19 WARNING [handle_message] webserver.py : Connection gracefully closed. 1001
2023-10-13 12:18:19 WARNING [handle_message] webserver.py : Traceback (most recent call last):
  File "/srv/managesieve/build/web/script/webserver.py", line 65, in handle_message
    handler.handle_request(context, request)
  File "/srv/managesieve/build/web/script/handler/websocket.py", line 48, in handle_request
    MessagePump().run(websocket, sievesocket)
  File "/srv/managesieve/build/web/script/messagepump.py", line 26, in run
    data = server.recv()
           ^^^^^^^^^^^^^
  File "/srv/managesieve/build/web/script/websocket.py", line 134, in recv
    raise Exception("Connection gracefully closed. "+str(code)+" "+text.decode())
Exception: Connection gracefully closed. 1001

What did you expect to happen?

If it's a graceful closure, then there should be no log entry, definitely not a traceback.

Which Version

Include information about your system, server and most important if it is about the app or webextension.