thsutton / aeson-diff

Generate and apply diffs between JSON documents.
BSD 2-Clause "Simplified" License
39 stars 21 forks source link

Does not respect RFC remove specification #47

Closed samtay closed 5 years ago

samtay commented 5 years ago

Removing keys whose values are arrays is broken. Example:

# original json
{ "foo": ["bar"], "baz": "quux"}

# patch
{ "op": "remove", "path": "/foo" }

# resulting json
{ "foo": ["bar"], "baz": "quux"}

This also breaks things that depend on remove, such as replace.

samtay commented 5 years ago

False alarm, sorry!

thsutton commented 5 years ago

No worries. If you can think of any additional test cases or documentation changes, please open an issue!