thtauhid / open-profile

Unified profile to showcase your work.
https://my-open-profile.vercel.app
MIT License
13 stars 14 forks source link

Enhancement: using the context hook to update the document title of the current Page #47

Closed kherin closed 1 year ago

kherin commented 1 year ago

Enhancement

Dynamically changing the document title based on the current page

vercel[bot] commented 1 year ago

Someone is attempting to deploy a commit to a Personal Account owned by @thtauhid on Vercel.

@thtauhid first needs to authorize it.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
open-profile ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 4, 2023 6:22pm
thtauhid commented 1 year ago

Build log:

[22:27:52.375] Running build in Washington, D.C., USA (East) – iad1 (Hive) [22:27:52.493] Cloning github.com/thtauhid/open-profile (Branch: enhancement/update-document-title, Commit: 2305cdd) [22:27:52.773] Cloning completed: 279.932ms [22:27:54.717] Restored build cache [22:27:54.788] Running "vercel build" [22:27:55.231] Vercel CLI 32.4.1 [22:27:55.831] Installing dependencies... [22:27:56.821] [22:27:56.821] up to date in 676ms [22:27:56.821] [22:27:56.821] 53 packages are looking for funding [22:27:56.821] run npm fund for details [22:27:56.833] Detected package-lock.json generated by npm 7+ [22:27:56.834] Running "npm run build" [22:27:57.241] [22:27:57.241] > open-profile@0.0.0 build [22:27:57.241] > tsc && vite build [22:27:57.241] [22:27:59.463] src/pages/Homepage.tsx(13,11): error TS2339: Property 'pageDetails' does not exist on type 'PageDetailContextValue | undefined'. [22:27:59.463] src/pages/Homepage.tsx(13,24): error TS2339: Property 'setPageDetails' does not exist on type 'PageDetailContextValue | undefined'. [22:27:59.463] src/pages/NotFound.tsx(7,11): error TS2339: Property 'pageDetails' does not exist on type 'PageDetailContextValue | undefined'. [22:27:59.463] src/pages/Profile/index.tsx(10,11): error TS2339: Property 'pageDetails' does not exist on type 'PageDetailContextValue | undefined'. [22:27:59.485] Error: Command "npm run build" exited with 2

image

thtauhid commented 1 year ago

Also, please merge the main branch into your feature branch to resolve possible merge conflicts.

kherin commented 1 year ago

If I directly visit the link of any page the page title does not update. Check https://open-profile-jgark6rvw-thtauhid.vercel.app/profile/thtauhid

Everything else looks good

@thtauhid I made the fix. Now the page title is updated when navigating directly to the profile url

thtauhid commented 1 year ago

Looks good,