search

thtauhid / open-profile

Unified profile to showcase your work.
https://my-open-profile.vercel.app
MIT License
13 stars 14 forks source link

Bug: Empty searches are allowed #68

Closed SAGARSINGH-1 closed 10 months ago

SAGARSINGH-1 commented 1 year ago

When a user press "enter" without a single character to input then it cause the empty box bug.

https://github.com/thtauhid/open-profile/assets/81561733/d2ccc35e-9c3d-47c5-a923-38f3f805f216

and yeah i am ready to work in this issue.

RobertLupas commented 11 months ago

Wouldn't it be better if the app wouldn't let you make empty searches in the first place? That would be easy to implement.

SAGARSINGH-1 commented 11 months ago

Yes it should be great idea.

Parmesh119 commented 11 months ago

Hi @SAGARSINGH-1, I am Parmesh Bhatt. I hope you are fine. Can you please assign this issue to me?

RobertLupas commented 11 months ago

I think the issue should be renamed to Bug: Empty searches are allowed, or something similar because that's the actual issue, and if it's fixed, the empty history boxes won't be a problem anymore.

SAGARSINGH-1 commented 11 months ago

hey @Parmesh119 I didn't have the permission to do it.

thtauhid commented 10 months ago

Anyone willing to take up this issue please let me know. @SAGARSINGH-1 @half-real-SCRACX @Parmesh119

RobertLupas commented 10 months ago

✋️

SAGARSINGH-1 commented 10 months ago

Yes I can @thtauhid

thtauhid commented 10 months ago

@half-real-SCRACX if you already haven't started working, please skip working on this issue. @SAGARSINGH-1 has already created a PR.

RobertLupas commented 10 months ago

Oh, ok, I'll work on the api one. Today was a busy day, and I accepted the task at night :)