Closed Ayansaxena24 closed 6 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
terminal-portfolio | ✅ Ready (Inspect) | Visit Preview | ✅ 1 resolved | Oct 11, 2023 5:33pm |
Hi @Ayansaxena24
Nice work.
Here are a few things you need to take care of before I can merge this PR -
.history
folder - This folder is not necessary and you might have added this folder by mistake. Please remove the folder from git. package.json
or package-lock.json
file unless you add/remove new dependency or create/remove new scripts. So, for this PR it'd be better not to push the package.json
or package-lock.json
file. Do let me know if you get stuck or need any help.
Looking forward to seeing you succeed in your open-source journey.
Regards THT
Hey @thtauhid Please give me the access to the Vercel Dashboard. I have requested for the same on vercel.
Secondly, can you please guide me on how to undo pushing the 'package.json' file?
Hi @Ayansaxena24
main
branch into your feature branch to solve any possible merge conflicts. package.json
and package-lock.json
from this PRJoin our Discord server to discuss ideas, ask questions, and collaborate with others.
So the easiest way to fix the issues with package.json
and package-lock.json
will be to do the following-
package.json
line 29"typescript": "^5.0.2",
package-lock.json
line 27"typescript": "^5.0.2",
Join our Discord server to discuss ideas, ask questions, and collaborate with others.
Hello @thtauhid I have removed the Hover Effect as required, but after resolving the merge conflicts Vercel deployment shows the status 'FAILED". Can you please throw some light on it? I have never used Vercel actually.
Give me some time. I'll check what's wrong.
@Ayansaxena24 somehow the .history folder got added again. Can you take care of that, please?
Once you take care of that, I'll check the deployment issue.
I asked GPT about this and I followed the same steps.
Do i need to delete the history folder from my local project completely and then push? Sorry for bothering you I am contributing in Open Source for the first time.
Sorry for bothering you I am contributing in Open Source for the first time.
Not an issue. Happy to help.
Run the following command-
git rm --cached -r .history
Add .history
in .gitignore
Then create a commit as usual.
Let me know if you need more help.
@thtauhid Can you check now please. Followed all the steps
@Ayansaxena24 there were some minor issues. Most probably it happened when you merged the main branch into your feature branch. It's solved now.
Don't forget to pull the changes to your local machine before doing new commits.
I'll review this PR in some time.
Hi @Ayansaxena24
terminal welcome message
in google. clear
command the welcome section has to go away. You can introduce a new state for that I think. Hey @thtauhid
- Whenever a user runs the
clear
command the welcome section has to go away. You can introduce a new state for that I think.
I have completed this. Couldn't understand what to do in the first change requested by you. Hope it is covered in my deployment. Please review it.
@Ayansaxena24 nice work. Here are a few things you need to address -
hey @thtauhid I have modified the CSS as required. I have solved the issue of the height of the gradient too without removing the gradient. Please review it.
Can you check the mobile view also?
It looks like this
Hello @thtauhid In my phone this view is available. I am not able to understand what changes are need to be made. Can you please describe in more detail?
Hello @thtauhid Can you please accept this for Hacktoberfest 2023?
Since the portfolio was not looking attractive, I have added a background color along with a heading and two subheadings with hints and instructions. Hope you will like it. I have used Tailwind CSS for styling here.
Portfolio after changes :![port](https://github.com/thtauhid/terminal-portfolio/assets/84512148/027a072a-665d-4a63-817d-82c35f20d82d)
Portfolio before changes :![port 0](https://github.com/thtauhid/terminal-portfolio/assets/84512148/95c6b0f0-b011-4047-aa92-d80fdc45ae6b)