thtauhid / terminal-portfolio

A portfolio site that looks and feels like a terminal. Built with React + Tailwind.
https://my-terminal-portfolio.vercel.app/
MIT License
25 stars 22 forks source link

Changed the bg color, terminal font, and added a heading #32

Closed Ayansaxena24 closed 6 months ago

Ayansaxena24 commented 9 months ago

Since the portfolio was not looking attractive, I have added a background color along with a heading and two subheadings with hints and instructions. Hope you will like it. I have used Tailwind CSS for styling here.

Portfolio after changes : port

Portfolio before changes : port 0

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terminal-portfolio ✅ Ready (Inspect) Visit Preview 1 resolved Oct 11, 2023 5:33pm
thtauhid commented 9 months ago

Hi @Ayansaxena24

Nice work.

Here are a few things you need to take care of before I can merge this PR -

Do let me know if you get stuck or need any help.

Looking forward to seeing you succeed in your open-source journey.

Regards THT

Ayansaxena24 commented 9 months ago

Hey @thtauhid Please give me the access to the Vercel Dashboard. I have requested for the same on vercel.

Secondly, can you please guide me on how to undo pushing the 'package.json' file?

thtauhid commented 9 months ago

Hi @Ayansaxena24

  1. Please merge the main branch into your feature branch to solve any possible merge conflicts.
  2. Here's the comment that I left previously. image
  3. I'll write a separate comment on how you can remove the package.json and package-lock.json from this PR

Join our Discord server to discuss ideas, ask questions, and collaborate with others.

thtauhid commented 9 months ago

So the easiest way to fix the issues with package.json and package-lock.json will be to do the following-

  1. Go to package.json line 29
  2. Replace the line with "typescript": "^5.0.2",
  3. Go to package-lock.json line 27
  4. Replace the line with "typescript": "^5.0.2",
  5. Commit & Push

Join our Discord server to discuss ideas, ask questions, and collaborate with others.

Ayansaxena24 commented 9 months ago

Hello @thtauhid I have removed the Hover Effect as required, but after resolving the merge conflicts Vercel deployment shows the status 'FAILED". Can you please throw some light on it? I have never used Vercel actually.

thtauhid commented 9 months ago

Give me some time. I'll check what's wrong.

thtauhid commented 9 months ago

@Ayansaxena24 somehow the .history folder got added again. Can you take care of that, please?

Once you take care of that, I'll check the deployment issue.

Ayansaxena24 commented 9 months ago

I asked GPT about this and I followed the same steps.

gfg

Do i need to delete the history folder from my local project completely and then push? Sorry for bothering you I am contributing in Open Source for the first time.

thtauhid commented 9 months ago

Sorry for bothering you I am contributing in Open Source for the first time.

Not an issue. Happy to help.

Run the following command-

git rm --cached -r .history

Add .history in .gitignore

Then create a commit as usual.

Let me know if you need more help.

Ayansaxena24 commented 9 months ago

@thtauhid Can you check now please. Followed all the steps

thtauhid commented 9 months ago

@Ayansaxena24 there were some minor issues. Most probably it happened when you merged the main branch into your feature branch. It's solved now.

Don't forget to pull the changes to your local machine before doing new commits.

I'll review this PR in some time.

thtauhid commented 9 months ago

Hi @Ayansaxena24

  1. Can we convert this welcome message + hints + introductions into a welcome section? Just search terminal welcome message in google.
  2. Whenever a user runs the clear command the welcome section has to go away. You can introduce a new state for that I think.
Ayansaxena24 commented 9 months ago

Hey @thtauhid

  1. Whenever a user runs the clear command the welcome section has to go away. You can introduce a new state for that I think.

I have completed this. Couldn't understand what to do in the first change requested by you. Hope it is covered in my deployment. Please review it.

thtauhid commented 9 months ago

@Ayansaxena24 nice work. Here are a few things you need to address -

  1. On the left side everything should be aligned image
  2. When I cross the default screen height I lose the background. Consider adding a solid color as a background and removing the gradient background maybe? image
Ayansaxena24 commented 9 months ago

hey @thtauhid I have modified the CSS as required. I have solved the issue of the height of the gradient too without removing the gradient. Please review it.

thtauhid commented 9 months ago

Can you check the mobile view also? It looks like this image

Ayansaxena24 commented 9 months ago

Hello @thtauhid In my phone this view is available. I am not able to understand what changes are need to be made. Can you please describe in more detail?

Screenshot_2023-10-10-17-55-36-45_40deb401b9ffe8e1df2f1cc5ba480b12

Ayansaxena24 commented 9 months ago

Hello @thtauhid Can you please accept this for Hacktoberfest 2023?