search

thtauhid / terminal-portfolio

A portfolio site that looks and feels like a terminal. Built with React + Tailwind.
https://my-terminal-portfolio.vercel.app/
MIT License
25 stars 22 forks source link

build: introduce react-icons #56

Closed sdanialraza closed 9 months ago

sdanialraza commented 9 months ago

This introduces react icons package and resolves #9.

vercel[bot] commented 9 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
terminal-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 2, 2023 8:37am
Kritika30032002 commented 9 months ago

adding react-icons library to the package.json does not create any effect as it is not used anywhere in the project.

sdanialraza commented 9 months ago

I wasn't sure if the icons can already be used somewhere, can they be?

Kritika30032002 commented 9 months ago

If it was used, then the library had been included. When we use any library then only we include it otherwise it affects performance of website.

sdanialraza commented 9 months ago

There was an issue open for this, so I would assume the icons would be used very soon.

Kritika30032002 commented 9 months ago

Okay

thtauhid commented 9 months ago

Currently, we are not using any icon library. We need to introduce an icon library.

Expected outcome: Users should be able to easily add icons to their data.json file. We'll also need to add support for displaying the icon. Currently, the app looks like this- image In the future when icon support is implemented we should be able to replace the text Email with an envelope icon.

Sorry for any confusion.