search

thuehlinger / daemons

Ruby daemons gem official repository
MIT License
648 stars 71 forks source link

Test Coverage? #28

Closed acuppy closed 9 years ago

acuppy commented 9 years ago

I'm not noticing any RSpec or MiniTest coverage for the gem. Is that by design or is there another mechanism? I'm planning to fork it and add assurances (tests) for a project that requires a certain level of coverage to be in place.

If there is not coverage in place, is coverage desired? and if so, is there a preference (RSpec or MiniTest)?

sodabrew commented 9 years ago

Unit tests are definitely needed, thank you for offering to begin them! I don't have a testing tool preference. @thuehlinger?

acuppy commented 9 years ago

Great. I'm going to start with RSpec and go from there. If it works to merge things in, great.

thuehlinger commented 9 years ago

I'm happy with either testing tool. Please go on. Thanks in advance!

acuppy commented 9 years ago

@sodabrew @thuehlinger Sounds good. I'll go forth.

acuppy commented 9 years ago

If you want to follow progress, check out my fork at https://github.com/acuppy/daemons

sodabrew commented 9 years ago

Looks good so far! One comment: I strongly recommend renaming your master branch to something descriptive of the project, like add_unit_tests, so that if we have other commits on this master branch while you're in progress it won't require any extra merges or messy rebase.

acuppy commented 9 years ago

For sure. I realized that after I started.

On Thursday, March 26, 2015, Aaron Stone notifications@github.com wrote:

Looks good so far! One comment: I strongly recommend renaming your master branch to something descriptive of the project, like add_unit_tests, so that if we have other commits on this master branch while you're in progress it won't require any extra merges or messy rebase.

— Reply to this email directly or view it on GitHub https://github.com/thuehlinger/daemons/issues/28#issuecomment-86595831.

Adam Cuppy Partner & COO | Coding ZEAL | Digital Artisans of Web and Mobile Applications 866.858.5988 x101 | 541.660.3681 | skype: adamcuppy | twitter: @codingzeal

acuppy commented 9 years ago

I'm closing this issue in lieu of the PR #32