search

thuehlinger / daemons

Ruby daemons gem official repository
MIT License
648 stars 71 forks source link

Add test coverage #32

Closed acuppy closed 9 years ago

acuppy commented 9 years ago

Run the suite: bundle exec rspec spec

sodabrew commented 9 years ago

This is totally awesome. Still in progress?

acuppy commented 9 years ago

Yes. I haven't had a lot of time. However, if it's passing, it is better than nothing to have a test suite in place.

acuppy commented 9 years ago

@thuehlinger this is a good time to merge this PR. It's not complete by any means, but it's passing and establishes some core contribution guidelines.

sodabrew commented 9 years ago

Rather than cherry-picking commits from master onto the branch, I'd recommend to rebase the branch up to master.

acuppy commented 9 years ago

@sodabrew it was rebased against master but not pushed. It's up to date now.

acuppy commented 9 years ago

Let me know if there's any other adjustments to get in there. Thanks!

pboling commented 9 years ago

:+1: This gem is important, and a test suite is also important for many corporate-pointy-haired-boss FOSS software approval processes.

acuppy commented 9 years ago

@thuehlinger any word on merging this in?

pboling commented 9 years ago

@acuppy The project may need additional maintainers that frequent Github more often.

thuehlinger commented 9 years ago

Merged. Thanks for the great work and my apologies for the delay.

acuppy commented 9 years ago

All good :)