thuehlinger / daemons

Ruby daemons gem official repository
MIT License
648 stars 71 forks source link

Add .travis.yml for Travis CI #42

Closed sodabrew closed 9 years ago

sodabrew commented 9 years ago

Now that there are unit tests, Travis CI provides a free public testing service: http://docs.travis-ci.com/user/getting-started/

thuehlinger commented 9 years ago

Thanks! Travis CI is now set up. However, the 1.8.7 and 1.9.3 tests fail since pry and byebug only install on >= 2.0.0. Do we need these for rspec?

sodabrew commented 9 years ago

I don't think so, pry and byebug are typically used for interactive debugging. We could move these from the .gemspec into the Gemfile, I can submit a PR later today for it.

sodabrew commented 9 years ago

I didn't notice, but there's also a circleci set up by @acuppy when he wrote the unit tests: https://circleci.com/gh/acuppy/daemons

Any preference for one service over the other? I've only used Travis CI for the past few years.

acuppy commented 9 years ago

Either should work fine. Travis is simple. On Mon, Oct 19, 2015 at 9:07 AM Aaron Stone notifications@github.com wrote:

I didn't notice, but there's also a circleci set up by @acuppy https://github.com/acuppy when he wrote the unit tests: https://circleci.com/gh/acuppy/daemons

Any preference for one service over the other?

— Reply to this email directly or view it on GitHub https://github.com/thuehlinger/daemons/pull/42#issuecomment-149260547.

thuehlinger commented 9 years ago

Good, then Travis it is.

Thomas

On 19.10.2015, at 18:09, Adam Cuppy notifications@github.com wrote:

Either should work fine. Travis is simple. On Mon, Oct 19, 2015 at 9:07 AM Aaron Stone notifications@github.com wrote:

I didn't notice, but there's also a circleci set up by @acuppy https://github.com/acuppy when he wrote the unit tests: https://circleci.com/gh/acuppy/daemons

Any preference for one service over the other?

— Reply to this email directly or view it on GitHub https://github.com/thuehlinger/daemons/pull/42#issuecomment-149260547.

— Reply to this email directly or view it on GitHub.