thulab / iotdb

This repository is ReadOnly now. please go to https://github.com/apache/incubator-iotdb
Apache License 2.0
19 stars 0 forks source link

weaken the function of BufferWriteRestoreManager #555

Closed jixuan1989 closed 5 years ago

jixuan1989 commented 5 years ago

After this PR, I will try to merge the two class BufferIO and BufferWriteRestoreManager into one: a TsFileIoWriter which has the ability to restore metadata.

codecov[bot] commented 5 years ago

Codecov Report

Merging #555 into kill_thanos will increase coverage by 3.48%. The diff coverage is 91.2%.

Impacted file tree graph

@@               Coverage Diff               @@
##           kill_thanos     #555      +/-   ##
===============================================
+ Coverage        50.59%   54.07%   +3.48%     
===============================================
  Files              416      416              
  Lines            33824    36055    +2231     
  Branches          7595     9914    +2319     
===============================================
+ Hits             17112    19497    +2385     
+ Misses           15261    14891     -370     
- Partials          1451     1667     +216
Impacted Files Coverage Δ
...nghua/tsfile/write/writer/DefaultTsFileOutput.java 64.28% <0%> (-10.72%) :arrow_down:
...singhua/iotdb/engine/overflow/ioV2/OverflowIO.java 57.83% <100%> (-13.8%) :arrow_down:
...u/tsinghua/tsfile/write/writer/TsFileIOWriter.java 94.08% <100%> (+0.61%) :arrow_up:
...du/tsinghua/iotdb/engine/bufferwrite/BufferIO.java 92.3% <60%> (-7.7%) :arrow_down:
...iotdb/engine/bufferwrite/BufferWriteProcessor.java 86.2% <87.5%> (+9.28%) :arrow_up:
.../engine/bufferwrite/BufferWriteRestoreManager.java 96.84% <96.82%> (+0.8%) :arrow_up:
...u/tsinghua/iotdb/qp/physical/crud/GroupByPlan.java 25% <0%> (-75%) :arrow_down:
...tsinghua/iotdb/qp/physical/crud/FillQueryPlan.java 33.33% <0%> (-66.67%) :arrow_down:
...inghua/iotdb/qp/physical/crud/AggregationPlan.java 57.14% <0%> (-42.86%) :arrow_down:
...ava/cn/edu/tsinghua/iotdb/service/JDBCService.java 50.8% <0%> (-27.95%) :arrow_down:
... and 104 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cac20ec...7c1de40. Read the comment docs.