search

thulasi-ram / django-feature-toggle

Feature Toggle implementation as a pluggable django app. Supports SimpleToggle, TimeBombToggle ways to manage release of new features that can be easily toggled on / off.
GNU General Public License v3.0
8 stars 2 forks source link

Add bool value (on/off) as toggle type (i.e attribute) #7

Open bittner opened 3 years ago

bittner commented 3 years ago

Currently, we have 4 choices the "key", which represents the type of feature toggle:

  1. module
  2. start_date
  3. end_date
  4. time_bomb

What seems to be missing is a simple "on/off" value, a boolean to turn a feature on or off.

Also, from the existing 4 attributes, only start_date and end_date are described in the docs. It would be nice to have their roles explained. The concept is a bit hard to grasp at the moment.

As a workaround and for simplicity, we have settled to use the is_active method as a boolean value. This is probably not what you designed it for. :smirk:

bittner commented 3 years ago

I figured that it's possible to create a toggle without any attribute, but then you have to set one using a valid key in order to update the toggle on the Admin UI. That feels a bit inconsistent.

thulasi-ram commented 3 years ago

is_active key is supposed to be used for case you have mentioned. or is there something I am missing?

Noted. will update the docs for start_date and end_date