search

thumblemonks / riot

Riot is a fast, expressive, and contextual ruby unit testing framework
http://thumblemonks.github.com/riot/
MIT License
314 stars 26 forks source link

conflict with rack-test and at_exit hook issues #34

Open lucashungaro opened 13 years ago

lucashungaro commented 13 years ago

I was trying to setup Riot + rack-test in a Rails app and got name conflicts with the options method, so I renamed it to option_set.

The second commit is to prevent an issue where a Rake::TestTask always reports a failure, despite the tests passing. I'm not sure I understood what you were trying to accomplish there, so feel free to fix it in a different way, of course. :)

achiurizo commented 13 years ago

i've pulled in your "conflict with rack-test" change here: 4008ad1ca53d35f04bd5dd1c94ea385ff160cf2f. For the at_exit hook change, i was unable to reproduce the error. I've encountered this error before but @jaknowlden and I recall that the code that exists there was to address this issue specifically. Thanks for the commit regardless. I'll keep an eye out and continue to see if this issue still pops up. I'm in the #riot irc room if you want to continue diving in this issue further. Thanks!

lucashungaro commented 13 years ago

Ok, I'll reinstall Ruby from scratch and try again.

lucashungaro commented 13 years ago

Ok, reinstalled Ruby 1.9.2 and tried again. Got the same errors.

achiurizo commented 13 years ago

Ok, i'll take a look again.

achiurizo commented 13 years ago

@lucashungaro is the rake test failure still an issue? @jaknowlden any ideas?

gus commented 13 years ago

I'll take a look this afternoon.

Justin Knowlden

On Wednesday, August 24, 2011 at 11:36 PM, achiu wrote:

@lucashungaro is the rake test failure still an issue? @jaknowlden any ideas?

Reply to this email directly or view it on GitHub: https://github.com/thumblemonks/riot/pull/34#issuecomment-1897088