search

thumblemonks / smurf

Rails plugin to automatically minify JavaScript and CSS when their bundles get cached
http://gusg.us/code/ruby/smurf-rails-autominifying-js-css-plugin.html
MIT License
193 stars 12 forks source link

Smurf not working correctly on rails 2.3.10 #11

Closed mcollina closed 13 years ago

mcollina commented 13 years ago

The latest version that support rails 2.3.x is v1.0.4, but in that version only the javascripts inside public/javascripts are minified. After digging up a little in the code, I've found that this should be solved in the latest v1.0.5 which works only on rails 3.

Is it too hard to support both rails2.3.x and rails3 on the same branch?

peppyheppy commented 13 years ago

The gem its self works on both 2.3.x and 3, but it depended on rails 3 for tests within the Gemfile. I just moved the rails dependency into the test environment in the Gemfile so you are no longer required to have rails 3 installed to use the gem with 2.3.x.

Because the tests use rails 3 there is no guarantee that older versions of rails will work, but they probably will anyway.

Good luck!

mcollina commented 13 years ago

That's fine :).

It's working smoothly on our rails 2.3.10 application, no issue at all.

Matteo