search

thumblemonks / smurf

Rails plugin to automatically minify JavaScript and CSS when their bundles get cached
http://gusg.us/code/ruby/smurf-rails-autominifying-js-css-plugin.html
MIT License
193 stars 12 forks source link

Can you please build a new version not requiring Rails 3.0.3? #15

Closed rynr closed 13 years ago

rynr commented 13 years ago

Rails 3.0.4 is out and it's not possible to update with the current smurf-version.

peppyheppy commented 13 years ago

Hi rjung,

You bring up a good point. Feel free to send over a patch with tests and I would be more than happy to accept it and push out a new version of the gem.

Thanks for using Smurf!

Paul

rynr commented 13 years ago

Well, f1997ec5e68462f955bf84db7420afad6ec26f6f already does fix the problem. You just need to build a new Gem-Version.

peppyheppy commented 13 years ago

The current gem is version 1.0.5. https://rubygems.org/gems/smurf/versions/1.0.5

Are you using the latest version that includes the commit you were referring to?

Paul

rynr commented 13 years ago

No, it's not fixed with 1.0.5. Take a look at the Dependencies at https://rubygems.org/gems/smurf/versions/1.0.5 . It says:

Runtime Dependencies

rails = 3.0.3

These are Runtime Dependencies. With the commit f1997ec5e68462f955bf84db7420afad6ec26f6f the Dependency is moved to the Development Dependencies within the Gemfile and is removed from the gemspec.

You just need to release a new Gem-Version with the current Gemfile.

By the way, Issue 16 is the same topic.

peppyheppy commented 13 years ago

Sorry for the confusion on this. It looks like the version was bumped but the change wasn't included. I just bumped the patch version after ensuring that all of the runtime dependencies were fixed. Please let me know if there is anything else. Thanks for your persistence on this.

Paul

rynr commented 13 years ago

Yeah, Thanks!