search

thumbor-community / aws

Thumbor AWS extensions
MIT License
155 stars 70 forks source link

latest version installs as v1 #119

Closed kkopachev closed 6 years ago

kkopachev commented 6 years ago

https://github.com/thumbor-community/aws/blob/a4ed80552114d079656add81160541cf9b29c8c3/setup.py#L12 I suspect it's due to how version is parsed.

root@c870fa791be9:/# pip install --no-cache-dir tc_aws==6.2.7 Collecting tc_aws==6.2.7 Downloading https://files.pythonhosted.org/packages/1c/bd/fdf425b0cf8edc4ed99a5bb6faa5150181d8f3971f07db0b04f0190016fb/tc_aws-6.2.7.tar.gz Requested tc_aws==6.2.7 from https://files.pythonhosted.org/packages/1c/bd/fdf425b0cf8edc4ed99a5bb6faa5150181d8f3971f07db0b04f0190016fb/tc_aws-6.2.7.tar.gz#sha256=3ce7f80ce54c3abed81b3242d841fb3345012d69321daa6c85f764a4c463e3c4, but installing version 1

Bladrak commented 6 years ago

Thanks for reporting, I'll take a look

Bladrak commented 6 years ago

Should be fixed by https://github.com/thumbor-community/aws/releases/tag/6.2.8 (hopefully) in commit https://github.com/thumbor-community/aws/commit/5b86a83f036f2aae9e6a49fc9226e6421441f6d1

kkopachev commented 6 years ago

@Bladrak could you publish it on pypi?

Bladrak commented 6 years ago

Sorry, didn't see that the deploy failed on CircleCI. I'll create a new tag with the fix, will probably be 6.2.9