Switch from pyvows to nosetest

thumbor-community / aws

Thumbor AWS extensions

MIT License

155 stars 70 forks source link

Switch from pyvows to nosetest #139

Closed kkopachev closed 4 years ago

kkopachev commented 4 years ago

Figured we should switch to nosetests from pyvows.

thumbor itself switched already
I have doubts vows were actually testing anything
I think that would help with Python3 migration

Bladrak commented 4 years ago

Wow great work, thanks a lot! Looks good so far, there's only one test failing in the CI, would you mind looking into it? https://circleci.com/gh/thumbor-community/aws/248?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

kkopachev commented 4 years ago

@Bladrak test fixed, should be good to go. I've changed signatures (added @return_future) of put_crypto and put_detector_data, but I didn't find any calls to them, so I think it's safe anyway.

Bladrak commented 4 years ago

Thanks, I'm away from computers at the moment but I'll take a look when I can, in a few days.

Bladrak commented 4 years ago

@kkopachev Merged, however the build seems to be failing, would you mind checking it?

kkopachev commented 4 years ago

Looks like it fails to checkout from git. Maybe you rotated your ssh key?

Bladrak commented 4 years ago

Hmm no but looks like it's an issue with the docker image, checking it. I'll let you know