search

thumbor-community / aws

Thumbor AWS extensions
MIT License
155 stars 70 forks source link

Support thumbor v7.x. #144

Closed b3g00d closed 1 year ago

b3g00d commented 4 years ago

as title

Bladrak commented 4 years ago

see #142

michaelurban commented 4 years ago

Is there an ETA for the 7.x update?

bagipriyank commented 3 years ago

this is blocking us from testing thumbor 7.x as well.

heynemann commented 3 years ago

There's a PR on thumbor (https://github.com/thumbor/thumbor/pull/1342) that will allow legacy extensions to be used. Can someone help test thumbor with S3 using the new compatibility layer?

dominik-bln commented 2 years ago

I just tried testing the compatibility layer, but running into the following problem:

Screenshot 2021-12-01 at 16 31 39

Would it be possible to publish a prerelease version that allows thumbor 7?

dominik-bln commented 2 years ago

I got thumbor 7 and tc_aws installed at the same time via pip install --no-deps tc_aws==6.2.15 and specifying the tc_aws deps manually. Now I am running into compatibility issues with Python 3:

thumbor_1  |   File "/usr/local/lib/python3.10/site-packages/tc_aws/loaders/__init__.py", line 9, in <module>
thumbor_1  |     import urllib2
thumbor_1  | ModuleNotFoundError: No module named 'urllib2'

So there is at least work to do in first porting the package to Python 3, before the compatibility layer can be tested.

dominik-bln commented 2 years ago

Nevermind, looks like compat layer is not even needed with this PR https://github.com/thumbor-community/aws/pull/147

Bladrak commented 2 years ago

You can now test a pre-release of the compatibility with Thumbor 7 & python 3 here: https://pypi.org/project/tc-aws/7.0b0/ and https://github.com/thumbor-community/aws/releases. Huge thanks to @amanagr and @peterrus for their contribution!

peterrus commented 2 years ago

And don't forget @jimas14! (:

peterrus commented 2 years ago

@Bladrak As you are probably more familiar with the project and it's history than I am: What would you consider to be the way forward to get this to be considered stable?

One thing I have noticed myself is that, while all unit test pass, we still have a ton of warnings, a portion of them related to deprecations: Test log of a recent build

By the way I am testing this pre release (7.0b0) out myself and I can report that all seems to working fine so far!

Bladrak commented 2 years ago

Thanks @jimas14 as well! Sorry I missed you :)

@peterrus I'd wait a few weeks to see if there are feedbacks from users before merging this to master and releasing a stable version. Ideally we should fix the warnings indeed.

Tenzer commented 2 years ago

What's needed before a release can be made with the Thumbor 7 related changes?

Bladrak commented 2 years ago

@Tenzer there's an alpha release available. We'll probably release a stable version in the coming weeks if no issues arise.

Tenzer commented 2 years ago

Ah, I had missed that. Thanks, I'll try it out soon.

charcoal3r commented 2 years ago

Hi, have been running this in production for a few weeks now without any issues. Processing hundredths of requests per week on about 5 instances combined. Just created this account to provide some feedback (:

heynemann commented 2 years ago

Awesome fedback @charcoal3r!!! Thank you for that!

aaugustin commented 1 year ago

Have issues arised since April? Or is the alpha stable enough to be released "for real"?

heynemann commented 1 year ago

We have many companies already running Thumbor 7 for real for a while now :) Go for it! Let us know how it goes.

heynemann commented 1 year ago

Regarding thumbor-community/aws I'll let the committers talk about it.

aaugustin commented 1 year ago

After posting, I discovered https://github.com/thumbor/thumbor-aws, which is probably the correct answer here.

Bladrak commented 1 year ago

Forgot about that, I'll release a stable release this week. Nice seeing you here @aaugustin by the way ;-)

peterrus commented 1 year ago

@Bladrak That'd be nice!

By the way, do we now have two thumbor plugins that provide AWS functionality? Do we want that?

Bladrak commented 1 year ago

@peterrus I wasn't aware that https://github.com/thumbor/thumbor-aws existed (I'm mostly maintaining this repo when I have some time), maybe this one is no longer needed. @heynemann maybe you can give a bit more insight? What are the main differences? Should we deprecate this repo in favor of the one on Thumbor org?

heynemann commented 1 year ago

TBH @Bladrak I created the other one just as a means to move adoption of 7.0.0 forward. There's not much different between them. Probably mine has bugs that this one doesn't :)

Bladrak commented 1 year ago

Version 7.0.2 has been released, and is stable. I'm closing this with this release, thanks to everyone who contributed on this! @heynemann let me know if you want to rationalise this, I'm not sure 2 repos make sense. I'm happy to help, whether in deprecating this repo, or moving it to the Thumbor org.