search

thumbor-community / aws

Thumbor AWS extensions
MIT License
155 stars 70 forks source link

Custom endpoint #68

Closed kevinmusker closed 8 years ago

kevinmusker commented 8 years ago

These changes allow a custom endpoint (e.g. an S3 compatible interface to a locally hosted service such as http://docs.ceph.com/docs/master/radosgw/s3/) to be specified in the thumbor config.

It used to be possible to specific a custom endpoint in the configuration of previous versions of boto, but not in boto3.

kevinmusker commented 8 years ago

I'll take a look at fixing these tests.

kevinmusker commented 8 years ago

I fixed a bug when constructing a Bucket for the storage backends (I had only considered the loader).

kevinmusker commented 8 years ago

@vmalaga, do you have the latest version?

e443d09a640fd53a7b8d3542f0fced889f2ad144 adds the missing argument to the Bucket construction.

kevinmusker commented 8 years ago

@Bladrak change made as requested - apologies for the delay.

Bladrak commented 8 years ago

Alright, seems good to me :) I'll let this open for a day or two in case anyone else would like to review it, and then merge it & release it.

Bladrak commented 8 years ago

This has been released on pypi as version 6.0.2

vmalaga commented 8 years ago

Hi @Bladrak sorry for the question, but i am not sure. This mean that the modifications @kevinmusker made to support a custom endpoint I can find it with

pip install tc_aws==6.0.2
Bladrak commented 8 years ago

Yes, should be fine with that :)