search

thumbor-community / aws

Thumbor AWS extensions
MIT License
155 stars 70 forks source link

Make check for TC_AWS_LOADER_BUCKET less strict. #83

Closed miracle2k closed 7 years ago

miracle2k commented 7 years ago

To support multiple buckets, TC_AWS_LOADER_BUCKET can be unset. However, any falsy value should count as "not set".

Reasoning:

  1. An empty bucket name doesn't make sense.
  2. Some deployment (i.e. config templating) approaches might make it difficult to set a None value.

Backwards-compatibility: Should be fine, as currently an empty bucket name raises an error anyway.

Specifically, I came across this trying to use https://github.com/APSL/docker-thumbor/blob/7a26c082146c3d6520d9eede4c8404a566bb35b0/thumbor/conf/thumbor.conf.tpl, which sets the value to an empty string.