search

thumbor / opencv-engine

Thumbor engine for the openCV imaging library.
MIT License
26 stars 26 forks source link

Deprecate old CV interface for openCV3 #32

Closed christianjgreen closed 6 years ago

christianjgreen commented 6 years ago

This PR is directed towards issue #15

openCV 3.x dropped the deprecated C API interface cv for the currently maintained C++ interface cv2.

A new engine was created using cv2 and numpy to support ongoing openCV development.

christianjgreen commented 6 years ago

@scorphus @savar @seffenberg-naspers @ustav2307 How's this? :)

savar commented 6 years ago

:D fine for me.. @anyone who is an owner here.. can we get this through?

Am 23. Dezember 2017 02:26:18 MEZ schrieb Christian Green notifications@github.com:

@scorphus @savar @seffenberg-naspers @ustav2307 How's this? :)

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/thumbor/opencv-engine/pull/32#issuecomment-353698749

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

savar commented 6 years ago

@heynemann @scorphus ?

savar commented 6 years ago

@Arthien maybe interesting for you and should be probably in this pull request as well:

https://github.com/naspersclassifieds-regional/coreservices-opencv-engine/commit/843f919fd846a3049b6a866d38a6b2e10efaa2b2

Enalmada commented 6 years ago

It would be very helpful for new users if opencv3 was either supported or well documented that it wasn't supported (docs imply that anything above 2.2 is ok). If support is nearly ready, please keep the momentum up to push this through.

christianjgreen commented 6 years ago

@Enalmada waiting the maintainers to merge still. The more community pressure we get the faster this can be pushed upstream.

bagipriyank commented 6 years ago

any update on this?

heynemann commented 6 years ago

Sorry for the delay. I'm not actually working with the opencv-engine. We are in dire need of maintainers.

christianjgreen commented 6 years ago

I'm still here!

On Wed, May 23, 2018, 5:07 PM Bernardo Heynemann notifications@github.com wrote:

Sorry for the delay. I'm not actually working with the opencv-engine. We are in dire need of maintainers.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/thumbor/opencv-engine/pull/32#issuecomment-391496665, or mute the thread https://github.com/notifications/unsubscribe-auth/AKLqPevDhcPfAzGCaTqTLsXRu3d6y32Eks5t1c-XgaJpZM4RLiPj .

heynemann commented 6 years ago

Do you wish to become a maintainer for opencv-engine?

christianjgreen commented 6 years ago

@heynemann I'd enjoy that thank you. Also looking at making a libvips engine for thumbor.

Enalmada commented 6 years ago

Awesome. BTW I noticed that an article about imgproxy labeled vips as an advantage over thumbor so it would be interesting to get thumbor using it too.

heynemann commented 6 years ago

@Arthien just added you as a committer! Welcome aboard! Looking forward to your libvips engine!

heynemann commented 6 years ago

Thanks for the pointer @Enalmada. I asked for some corrections in the article you pointed to at https://github.com/DarthSim/imgproxy/issues/58

Hope Sergey does update his article! Anyways, I hope more open source options do appear. The diversity in the imaging ecosystem improves all the options and is beneficial to all devs.

savar commented 6 years ago

Me too! @arthien did you already compare somehow libvips with opencv? Or is there a good article about it?

Am 24. Mai 2018 02:04:13 MESZ schrieb Bernardo Heynemann notifications@github.com:

@Arthien just added you as a committer! Welcome aboard! Looking forward to your libvips engine!

-- You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/thumbor/opencv-engine/pull/32#issuecomment-391541846

-- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.