search

thumbor / thumbor

thumbor is an open-source photo thumbnail service by globo.com
http://thumbor.org
MIT License
9.9k stars 825 forks source link

Asynchronous file operations - os library #1650

Closed OndrejIT closed 6 days ago

OndrejIT commented 2 months ago

Hello, While tuning thumbor for the company I work for, which handles a lot of traffic, I noticed that all the work with the files is not asynchronous (https://github.com/thumbor/thumbor/blob/master/thumbor/loaders/file_loader.py#L41 atc..). Thumbor uses the standard os library, which itself is blocking. Or am I mistaken? If I'm right, I'd like to fix this with, for example, the aiofiles library that wraps the standard os, but I'd hate to do something unnecessary.

RaphaelVRossi commented 2 months ago

Hey @OndrejIT, thanks for reaching out.

Yes, in this case Thumbor is using the standard os library.

Thanks again for your time and consideration!

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 30 days with no activity. Remove the stale label or add a comment, or this issue will be closed in 15 days. You can always re-open if you still feel this is still an issue. Tag @heynemann for more information.

github-actions[bot] commented 6 days ago

This issue was closed because it has been stale for 15 days with no activity.