search

thumbtack / thumbprint-tokens

Design variables that power Thumbtack’s UI.
https://thumbprint.design/tokens/
Apache License 2.0
9 stars 1 forks source link

Add font, font weight, and border radius for iOS #22

Closed kevinmbeaulieu closed 4 years ago

kevinmbeaulieu commented 4 years ago

1) Add iOS exports for font, font weight, and border radius tokens ~2) Add support for a platform-specific memberName when simply using {{removeSpaces this.name}} could create a conflict (in this case, the iOS repo is defining class Font with constants for the actual UIFont instances, whereas what's being exported as part of this pod is simply the values for the font size & weight. Therefore it seemed more appropriate to name this pod's member FontAttributes.~ Realized this wasn't necessary after all ~3) Add support for a token.platforms.ios.type property to specify how each token should be defined. Previously, all tokens were defined as constants (public static let ...), but now there is also an enumCase option which will define them as case ... (useful for font weight, which is semantically an enum with no raw values).~

kevinmbeaulieu commented 4 years ago

By "Add font", did you mean a reference to TT Mark? Or something else?

I mean add the tokens that are named Font in tokens.js

danoc commented 4 years ago

Looks great. Thanks for the changes!