search

thumbtack / thumbprint-tokens

Design variables that power Thumbtack’s UI.
https://thumbprint.design/tokens/
Apache License 2.0
9 stars 1 forks source link

Add iOS-specific font tokens #24

Closed kevinmbeaulieu closed 4 years ago

kevinmbeaulieu commented 4 years ago

Adding a few fonts & properties that are specific to iOS, but that I think still make sense to be in this repo: (1) Fonts for tab bars and navigation bars (2) a UIFont.TextStyle property which is an Apple-specified enum of text styles which we have to map each of our text styles to when supporting Dynamic Type. There isn't a perfect 1:1 mapping, but all it's really used for is deciding the rate at which a given font should scale (e.g., at the extraLarge text size setting, maybe .body fonts will be scaled up by 1.1 but .headline fonts only by 1.05 or something). Given that the characteristics of Thumbprint text styles are specified in this repo, it seems like this should live here too

danoc commented 4 years ago

Hey! I agree that the "UIFont.TextStyle" ones make sense.

Before we add the tab and navigation bar ones, I think it'd be good to come up with a plan for how to name and document component level tokens. This is something we want to do more of, but I think it'd be good to make sure that the approach we take here will work for all components.

What do you think?

kevinmbeaulieu commented 4 years ago

Oh currently we have those fonts mixed in with all the other fonts, instead of embedded in the nav/tab bar components, but I think that does make more sense. I'll remove them here and then in iOS move them to be baked into the components

kevinmbeaulieu commented 4 years ago

@danoc Updated, and made the corresponding iOS cleanup here https://github.com/thumbtack/ios/pull/7136