thuml / Anomaly-Transformer

About Code release for "Anomaly Transformer: Time Series Anomaly Detection with Association Discrepancy" (ICLR 2022 Spotlight), https://openreview.net/forum?id=LzQQ89U1qm_
MIT License
733 stars 190 forks source link

Why use test_loader instead of validation_loader? #50

Open missflash opened 1 year ago

missflash commented 1 year ago

I think you should use validation_loader instead of test_loader in the following self.vali function.

https://github.com/thuml/Anomaly-Transformer/blob/e11c317974b729d330b8f84de0619902c3b5cee9/solver.py#L196

umivic commented 1 month ago

I agree with you. The test dataset should never be used as a validation set during the training process. This practice can lead to data leakage and result in overly optimistic performance evaluations. Any reported test performance metrics would be artificially high and not reflective of the model’s actual ability to generalize to unseen data.