Missing requirements to be installed in `setup.py`

thuml / Transfer-Learning-Library

Transfer Learning Library for Domain Adaptation, Task Adaptation, and Domain Generalization

http://transfer.thuml.ai

MIT License

3.39k stars 553 forks source link

Closed phamour closed 2 years ago

phamour commented 2 years ago

Describe the bug In setup.py, requirements to be installed are hardcoded and inconsistent with requirements.txt.

To Reproduce Steps to reproduce the behavior:

Under a clean env (say a new virtual env), install tllib from source through pip install .
Call python -c "from tllib.ranking import log_maximum_evidence"
See error "ModuleNotFoundError: No module named 'numba'"

Expected behavior No import error after a clean installation.

Screenshots

thucbx99 commented 2 years ago

Thanks for pointing this out and providing a neat solution！