thuml / Transfer-Learning-Library

Transfer Learning Library for Domain Adaptation, Task Adaptation, and Domain Generalization
http://transfer.thuml.ai
MIT License
3.39k stars 553 forks source link

ADDA Architecture #172

Closed evablanco closed 1 year ago

evablanco commented 2 years ago

Hi,

I am trying to modify ADDA from your code. In the original paper, there seems to be 2 CNNs in the second training phase, one to process the examples of the target set and another with the frozen weights to process the examples of the source set. In this way, the CNN of the target set is 'adjusted' to that of the source set depending on the output of the domain discriminator.

However, when reviewing the code it seems that only a single CNN is used, adjusting in a first phase the model (extractor+classifier) and in a second phase only the domain discriminator. My questions is how then the training of both phases is reproduced in the library. Thank you very much!

Best regards,

Eva

thucbx99 commented 1 year ago

Hi,

Indeed, the current implementation is different from the original ADDA.