search

thuml / Transfer-Learning-Library

Transfer Learning Library for Domain Adaptation, Task Adaptation, and Domain Generalization
http://transfer.thuml.ai
MIT License
3.39k stars 553 forks source link

Importing wrong DomainAdversarialLoss #179

Closed kiranchari closed 1 year ago

kiranchari commented 1 year ago

Describe the bug

The code imports tllib.alignment.dann.DomainAdversarialLoss instead of tllib.alignment.adda.DomainAdversarialLoss in adda.py (see https://github.com/thuml/Transfer-Learning-Library/blob/master/examples/domain_adaptation/image_classification/adda.py#L25)

Is this correct?

thucbx99 commented 1 year ago

Yes, and this is because we implemented several modified versions of ADDA but only kept the better performing one. You can refer to issue172 for details.

kiranchari commented 1 year ago

ok thanks