search

thunder-engine / thunder

Thunder Engine – Cross-platform 2D and 3D game engine with modular architecture
https://thunderengine.org/
Apache License 2.0
521 stars 34 forks source link

Fix: Assimp StackAllocator Upstream Code Fix #781

Closed bedwardly-down closed 5 days ago

bedwardly-down commented 1 week ago

My original StackAllocator fix has been accepted and merged upstream: https://github.com/assimp/assimp/pull/5650

I've updated CMake to work with it. I may still need to enforce qbs to use c++17 for the builds to pass. The latest master uses it for its CMake (see here).

eprikazchikov commented 6 days ago

Please do re-base on latest master

bedwardly-down commented 6 days ago

Please do re-base on latest master

! [remote rejected] assimp-upgrade -> assimp-upgrade (refusing to allow a Personal Access Token to create or update workflow .github/workflows/main.yml without workflow scope) error: failed to push some refs to 'https://github.com/bedwardly-down/thunder-bsd.git'

It didn't like the workflow part.

Give me a sec. It's my fault.

bedwardly-down commented 6 days ago

I forgot to give myself the workflow scope in my token. :sweat:

bedwardly-down commented 6 days ago

Looks like this is a known issue: https://developercommunity.visualstudio.com/t/error-c2872-byte-ambiguous-symbol/93889 .

bedwardly-down commented 6 days ago

According to this, the qt version built with may be too old for MSVC 2022.

eprikazchikov commented 6 days ago

no the issue in using namespace std; Im removing it in global scope

bedwardly-down commented 5 days ago

https://github.com/thunder-engine/thunder/pull/786 this gets merged, I'll move my changes into it and then push a new commit. It's easy to redo it and push without my junk.

eprikazchikov commented 5 days ago

ok now please rebase on latest master