search

thunder-engine / thunder

Thunder Engine – Cross-platform 2D and 3D game engine with modular architecture
https://thunderengine.org/
Apache License 2.0
521 stars 34 forks source link

Fix: Hard path Fix #778 #782

Closed bedwardly-down closed 6 days ago

bedwardly-down commented 6 days ago

This may not fully fix the issue (need to test after work), but the original hard path would break installing resources if building with CMake out of source tree (how I build to keep from accidentally polluting my source tree and any repo I send code to); ../worldeditor/bin wouldn’t always exist unless the developer created it themselves prior to building.

bedwardly-down commented 6 days ago

Pushing a fix for this in a short while. Just tested at home. It's not quite right yet. Threw this error like I thought it might.

CMake Error at build/cmake_install.cmake:41 (file):
  file INSTALL cannot find "/home/brad/git/thunder-build/worldeditor/bin": No
  such file or directory.
bedwardly-down commented 6 days ago

This didn't solve the core issue but does guarantee that resources will always be installed from the correct location.