search

thunder-project / thunder

scalable analysis of images and time series
http://thunder-project.org
Apache License 2.0
814 stars 184 forks source link

Error when using thunder-ec2 with spark 1.3.0 #133

Open npyoung opened 9 years ago

npyoung commented 9 years ago

Calling thunder-ec2 start gives me

Starting slaves...
Starting master...
Traceback (most recent call last):
  File "/usr/local/lib/python2.7/site-packages/thunder_python-0.5.0_dev-py2.7.egg/thunder/utils/ec2.py", line 563, in <module>
    opts=opts)
TypeError: wait_for_cluster_state() takes exactly 4 arguments (3 given)

This is because spark_ec2.py:wait_for_cluster_state now accepts an additional connection argument as of 1.3.0.

Adding conn=conn to the argument list in both calls to wait_for_cluster_state in thunder/utils/ec2.py fixes this error for me.

freeman-lab commented 9 years ago

Would be great to know if it works (without your manual patch) if you update to master now. You definitely flagged the right issue, I caught the first usage here https://github.com/thunder-project/thunder/commit/a2e8f8d7ac766581d6a479017947b48e5c196f16 and just pushed a change for the other

andrewgiessel commented 9 years ago

Is this fixed? @freeman-lab