search

thunder-project / thunder

scalable analysis of images and time series
http://thunder-project.org
Apache License 2.0
814 stars 184 forks source link

Blocking scheme update #311

Closed jwittenbach closed 8 years ago

jwittenbach commented 8 years ago

Closes #307

freeman-lab commented 8 years ago

@jwittenbach looking good, left a couple comments. Didn't totally follow the automatic size calculation. And it's slightly confusing for us to say that a size of of auto means we'll pick a chunk_size to make the intermediate objects 1000 kb, but that's then very different than what you'd get if you specify a chunk_size of 1000 kb. Not sure there's a better way though.

jwittenbach commented 8 years ago

@freeman-lab I think this is ready to go now, though it might be good if you took one last look at it :)

freeman-lab commented 8 years ago

looks good to me!