search

thunder-project / thunder

scalable analysis of images and time series
http://thunder-project.org
Apache License 2.0
814 stars 184 forks source link

BotoParallelReader bug #329

Closed boazmohar closed 8 years ago

boazmohar commented 8 years ago

Trying to run data = td.images.fromexample(name='mouse',engine=None) fails due to a change from #313 as the accessor function expects 3 params. This PR fixes that, still don't know if related to #327 There are no tests for the BotoParallelReader, seems very hard to mock AWS. @freeman-lab Is there another way?

freeman-lab commented 8 years ago

Looks good @boazmohar ! Just a style nit. Thanks for catching this. I think #327 was a different error though.

boazmohar commented 8 years ago

Sure thing @freeman-lab I prefer finding the bugs I made first :)